Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when sending image with latest posthog #2196

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix crash when sending image with latest posthog #2196

merged 1 commit into from
Jan 9, 2024

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds proguard rule to keep an Android internal method even if it's unused.

Motivation and context

Latest proguard version 3.1.0 crashes the app when sending a picture in release mode.

Thanks @surakin for the tentative fix.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner January 8, 2024 15:14
@jmartinesp jmartinesp requested review from bmarty and removed request for a team January 8, 2024 15:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XcGiC1

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afacef0) 67.01% compared to head (e63eb3a) 67.01%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2196   +/-   ##
========================================
  Coverage    67.01%   67.01%           
========================================
  Files         1376     1376           
  Lines        34263    34263           
  Branches      7460     7460           
========================================
  Hits         22961    22961           
  Misses        7677     7677           
  Partials      3625     3625

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fix tested OK!

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 9, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 9, 2024
@bmarty bmarty enabled auto-merge January 9, 2024 10:54
@bmarty bmarty merged commit 07776f0 into develop Jan 9, 2024
19 checks passed
@bmarty bmarty deleted the fix/jme-crash-sending-picture-with-latest-posthog branch January 9, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartinesp @bmarty